mspertus closed this revision.
mspertus added a comment.
Committed as revisions 264601 and 264602
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio added a comment.
In http://reviews.llvm.org/D18497#384362, @mspertus wrote:
> In http://reviews.llvm.org/D18497#384351, @ariccio wrote:
>
> > Otherwise, assuming everything builds correctly, LGTM.
>
>
> There are a lot scenarios. What do all of these files in the build tree like
> `cmake
mspertus updated this revision to Diff 51764.
mspertus added a comment.
Adding missing period in comment!
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/LLVMVisualizers/CMakeLists.txt
utils/LLVMVisualizers/llvm.natvis
utils/llvm.natvis
Index: utils/llvm.natvis
=
mspertus added a comment.
In http://reviews.llvm.org/D18497#384351, @ariccio wrote:
> `utils/llvm.natvis` is a duplicate of `utils/LLVMVisualizers/llvm.natvis`?
The file was moved to a more appropriate directory (Otherwise, the project
files were stepping on each other).
`svn mv utils/llvm.nat
ariccio added a comment.
`utils/llvm.natvis` is a duplicate of `utils/LLVMVisualizers/llvm.natvis`?
Otherwise, assuming everything builds correctly, LGTM.
Once again, thanks for doing this!
http://reviews.llvm.org/D18497
___
cfe-commits mailing li
mspertus updated this revision to Diff 51756.
mspertus added a comment.
Add missing newline
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/LLVMVisualizers/CMakeLists.txt
utils/LLVMVisualizers/llvm.natvis
utils/llvm.natvis
Index: utils/llvm.natvis
===
mspertus updated this revision to Diff 51754.
mspertus added a comment.
Since this is now creating a project, we should do some housekeeping to move
the files to different directories so that the build tree has an
LLVMVisualizers project directory.
http://reviews.llvm.org/D18497
Files:
CMak
mspertus marked an inline comment as done.
mspertus added a comment.
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus updated this revision to Diff 51740.
mspertus added a comment.
Missed one (the missing period in llvm.natvis).
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
--- ut
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
mspertus marked 3 inline comments as done.
mspertus added a comment.
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus updated this revision to Diff 51739.
mspertus added a comment.
Accepting Aaron's suggestions
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
--- utils/llvm.natvis
++
aaron.ballman added a comment.
This is fantastic! Just a few nits, but nothing substantial.
Comment at: CMakeLists.txt:739
@@ +738,3 @@
+# tries to create a corresponding executable, which we don't want
+if(LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION)
+ set( LLVM_VISUALIZERS utils/
mspertus updated this revision to Diff 51735.
mspertus added a comment.
Correctly handle non-Visual Studio case (e.g., Linux)
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
14 matches
Mail list logo
