Re: [PATCH] D18408: readability check for const params in declarations

2016-03-31 Thread Matthew Fowles Kulukundis via cfe-commits
I tried manually specifying --create. The problem was that my commit message had stuff from an early arc diff still in it which arc was picking up and getting confused by. Matt On Thu, Mar 31, 2016 at 8:29 AM, Alexander Kornienko wrote: > On Wed, Mar 30, 2016 at 4:01 PM, Matthew Fowles Kulukun

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-31 Thread Alexander Kornienko via cfe-commits
On Wed, Mar 30, 2016 at 4:01 PM, Matthew Fowles Kulukundis < matt.fow...@gmail.com> wrote: > My attempts to do this end with: > > $ arc diff > I normally use `arc diff --create` or `arc diff --update D`, and this works. > Linting... > No lint engine configured for this project. > Running un

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Matt Kulukundis via cfe-commits
fowles added a comment. Helped by sbenza@ http://reviews.llvm.org/D18608 Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Matthew Fowles Kulukundis via cfe-commits
Helped by sbenza@ http://reviews.llvm.org/D18608 On Wed, Mar 30, 2016 at 12:54 PM, Richard wrote: > LegalizeAdulthood added a comment. > > Maybe you need to rebase first? I haven't used arc. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D18408 > > > > ___

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. Maybe you need to rebase first? I haven't used arc. Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Matt Kulukundis via cfe-commits
fowles added a comment. that is what I was trying to do. I can't seem to make arc play nice. Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Richard via cfe-commits
LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. You can submit the release notes changes in a new patch. Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Matt Kulukundis via cfe-commits
fowles added a subscriber: fowles. fowles added a comment. My attempts to do this end with: $ arc diff Linting... No lint engine configured for this project. Running unit tests... No unit test engine is configured for this project. SKIP STAGING Unable to determine repository for this change. Ex

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Matthew Fowles Kulukundis via cfe-commits
My attempts to do this end with: $ arc diff Linting... No lint engine configured for this project. Running unit tests... No unit test engine is configured for this project. SKIP STAGING Unable to determine repository for this change. Exception ERR_CLOSED: This revision has already been closed. (

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Actually, we missed one thing: may I ask you to update docs/ReleaseNotes.rst with a short description of the new check? Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-30 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264856: [clang-tidy] readability check for const params in declarations (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18408?vs=51954&id=52037#toc Repository: rL LLVM http:/

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-29 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 51954. fowles marked 2 inline comments as done. fowles added a comment. - review comments - rename variables and remove MSVC compat issues http://reviews.llvm.org/D18408 Files: clang-tidy/readability/AvoidConstParamsInDecls.cpp clang-tidy/readability/Avo

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-29 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Thank you for the new check! Do you need me to submit the patch for you? Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:24 @@ +23,3 @

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-29 Thread Matt Kulukundis via cfe-commits
fowles added a comment. ping? http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-24 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 51596. fowles marked 5 inline comments as done. fowles added a comment. - review comments http://reviews.llvm.org/D18408 Files: clang-tidy/readability/AvoidConstParamsInDecls.cpp clang-tidy/readability/AvoidConstParamsInDecls.h clang-tidy/readability/C

Re: [PATCH] D18408: readability check for const params in declarations

2016-03-24 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Looks good in general. A few nits. Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:22 @@ +21,3 @@ + +SourceRange GetTypeRange(const ParmVarDecl &Param) { + if (Param.getIdentifier() != nullptr) "Function names ... should b