Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

WuZhao added a comment. I wan to point to some issues, because I am also doing AIX support based on your patch and I tested and verified. Firstly, in the lib/Driver/ToolChains.cpp line 3756 case llvm::Triple::ppc64: addPathIfExists(D, getDriver().SysRoot + getDriver().Dir + "/../lib64",

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D18360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki updated this revision to Diff 64518. apaprocki added a comment. Increased context and removed accidental inclusion of Solaris change. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driv

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer added a comment. Could you please attach a diff with additional context? Comment at: lib/Driver/ToolChains.cpp:3717-3735 @@ -3678,1 +3716,21 @@ + // We need a detected GCC installation on Linux to provide libstdc++'s + // headers. We handled the libc++ case above. +

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki updated this revision to Diff 64376. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h tools/libclang/CIndexer.cpp Index: tools/libclang/CIndexer.cpp

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); majnemer wrote: > apaprocki wrote: > > majnemer wrote: > >

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); apaprocki wrote: > majnemer wrote: > > Are we really suppose

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); majnemer wrote: > Are we really supposed to define this mac

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer added a subscriber: majnemer. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); Are we really supposed to define this macro? Does GC

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki added a comment. (I also re-based the patch on top of `trunk`) https://reviews.llvm.org/D18360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki updated this revision to Diff 64328. apaprocki added a comment. Fixed `wchar_t` type. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h tools/libcla

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

WuZhao added a subscriber: WuZhao. WuZhao added a comment. Hi , I find one mistake in the lib/Basic/Targets.cpp. On my AIX 7.1 machine /usr/include/sys/inttypes.h, 64 bits wchar_t is unsigned int, not signed int. #ifndef _WCHAR_T #define _WCHAR_T #ifdef __64BIT__ typedef unsigned int