etienneb updated this revision to Diff 51305.
etienneb added a comment.
rebase + fixing invalid paths
http://reviews.llvm.org/D18262
Files:
clang-tidy/ClangTidy.cpp
test/clang-tidy/misc-macro-parentheses-cmdline.cpp
Index: test/clang-tidy/misc-macro-parentheses-cmdline.cpp
alexfh accepted this revision.
alexfh added a comment.
LG. Thanks for the fix!
http://reviews.llvm.org/D18262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D18262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
etienneb updated this revision to Diff 51046.
etienneb marked 2 inline comments as done.
etienneb added a comment.
Added test.
http://reviews.llvm.org/D18262
Files:
ClangTidy.cpp
misc-macro-parentheses-cmdline.cpp
Index: misc-macro-parentheses-cmdline.cpp
==
etienneb added inline comments.
Comment at: ClangTidy.cpp:144
@@ -138,1 +143,3 @@
+
+Diag << FixItHint::CreateReplacement(Range, Fix.getReplacementText());
++TotalFixes;
alexfh wrote:
> aaron.ballman wrote:
> > Is there a purpose to emittin
alexfh added a comment.
Thank you, Etienne!
Please add a regression test.
Comment at: ClangTidy.cpp:144
@@ -138,1 +143,3 @@
+
+Diag << FixItHint::CreateReplacement(Range, Fix.getReplacementText());
++TotalFixes;
aaron.ballman wrote:
> Is
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
Thank you for working on this! A question below, but also, the patch is missing
test cases for the change.
Comment at: ClangTidy.cpp:144
@@ -138,1 +143,3 @@
+
+Diag << FixItHint::Crea
