Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-30 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. No, thank you for the fix! LG http://reviews.llvm.org/D18243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-30 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware added a comment. Are there any other comments please? http://reviews.llvm.org/D18243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-23 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware updated this revision to Diff 51437. baloghadamsoftware added a comment. Release notes fixed. http://reviews.llvm.org/D18243 Files: docs/LibASTMatchersReference.html docs/ReleaseNotes.rst include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTest.cp

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-23 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: docs/ReleaseNotes.rst:123 @@ +122,3 @@ +- hasAnyArgument: Matcher no longer ignores parentheses and implicit casts on + the argument before applying the inner matcher. The fix was done allow for + greater control by the user. In all exis

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-22 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware updated this revision to Diff 51287. baloghadamsoftware added a comment. Release notes updated. http://reviews.llvm.org/D18243 Files: docs/LibASTMatchersReference.html docs/ReleaseNotes.rst include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTest.

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-22 Thread Alexander Kornienko via cfe-commits
alexfh added a subscriber: alexfh. alexfh added a comment. > the fix must be emphasized in the release notes It seems like the best time to update the release notes is now, in this patch ;) http://reviews.llvm.org/D18243 ___ cfe-commits mailing

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-22 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware updated this revision to Diff 51263. baloghadamsoftware added a comment. LibASTMatchersReference.html updated http://reviews.llvm.org/D18243 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTest.cpp Index

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-21 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware updated this revision to Diff 51167. http://reviews.llvm.org/D18243 Files: include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTest.cpp Index: unittests/ASTMatchers/ASTMatchersTest.cpp ===

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

2016-03-19 Thread Samuel Benzaquen via cfe-commits
sbenza added a comment. Please add a test for this. http://reviews.llvm.org/D18243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits