Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Eric Fiselier via cfe-commits
EricWF added a comment. The method @bcraig is describing is documented here: http://libcxx.llvm.org/docs/BuildingLibcxx.html#id4 http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Ben Craig via cfe-commits
bcraig added a comment. In http://reviews.llvm.org/D18174#375813, @raj.khem wrote: > I think my problem was that while compiling libcxxabi, it wants to peek into > libcxx headers but then libcxxabi cmake infra doesnt have the musl support > like libcxx. So Now I solved it by adding -D_LIBCPP_HA

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Eric Fiselier via cfe-commits
EricWF added a comment. That patch looks hugely dangerous because you've now changed when your static mutex's get initialized. Please file a bug against libc++. http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Khem Raj via cfe-commits
raj.khem added a comment. libcxx still has problem compiling on musl/aarch64 though. I fixed it with this patch https://github.com/kraj/meta-clang/blob/master/recipes-devtools/clang/libcxx/0001-use-constexpr-when-using-glibc.patch does this make sense ? http://reviews.llvm.org/D18174 _

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Eric Fiselier via cfe-commits
EricWF added a subscriber: EricWF. EricWF added a comment. @raj.khem Can you file a bug against libc++abi please? http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Khem Raj via cfe-commits
raj.khem added a comment. I think my problem was that while compiling libcxxabi, it wants to peek into libcxx headers but then libcxxabi cmake infra doesnt have the musl support like libcxx. So Now I solved it by adding -D_LIBCPP_HAS_MUSL_LIBC to CXXFLAGS. http://reviews.llvm.org/D18174 ___

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Ben Craig via cfe-commits
bcraig added a comment. The trouble is that features.h doesn't exist in musl (as far as I know). That's the biggest reason why _LIBCPP_HAS_MUSL_LIBC is needed. http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Khem Raj via cfe-commits
raj.khem added a comment. 3.8 has it in there. So may be this is just not required. I will add -DLIBCXX_HAS_MUSL_LIBC=ON to Cmake and see what comes out http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Khem Raj via cfe-commits
raj.khem added a comment. @bcraig, right, check for __GLIBC__ can be moved after including features.h. https://chromium.googlesource.com/native_client/pnacl-libcxx/+/master%5E!/ seems to add needed tweaks which can be enabled by passing -D__musl__ in CFLAGS may be it can be backported to 3.8 bran

Re: [PATCH] D18174: Fix libcxx build on musl

2016-03-15 Thread Ben Craig via cfe-commits
bcraig added a comment. If I understand it correctly, __GLIBC__ is defined in features.h, so this won't work. I suspect that the build isn't broken. You likely just need to define LIBCXX_HAS_MUSL_LIBC on your cmake line. That will cause __config_site.in to #define _LIBCPP_HAS_MUSL_LIBC for y