joker.eph closed this revision.
joker.eph added a comment.
r263257
http://reviews.llvm.org/D18024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
joker.eph updated this revision to Diff 50282.
joker.eph added a comment.
Add a FIXME to change the compile time switch to a runtime command line flag
http://reviews.llvm.org/D18024
Files:
lib/CodeGen/CGBuilder.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenAction.cp
chandlerc added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:660-663
@@ -660,1 +659,6 @@
+ OwnsVMContext(!_VMContext) {
+#ifdef NDEBUG
+ _VMContext.setDiscardValueNames(true);
+#endif
+}
joker.eph wrote:
> chandlerc wrote:
> > I'm surprised t
joker.eph added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:660-663
@@ -660,1 +659,6 @@
+ OwnsVMContext(!_VMContext) {
+#ifdef NDEBUG
+ _VMContext.setDiscardValueNames(true);
+#endif
+}
chandlerc wrote:
> I'm surprised this isn't a driver-si
chandlerc added a comment.
FYI, I'd lik eto hold off on submitting here until we're on the same page with
Philip on the original LLVM review (http://reviews.llvm.org/D17946), but some
comments on how this is working are below...
Comment at: lib/CodeGen/CodeGenAction.cpp:660-66
