Re: [PATCH] D17959: Make it possible for AST plugins to enable themselves by default

2016-03-15 Thread John Brawn via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263546: Make it possible for AST plugins to enable themselves by default (authored by john.brawn). Changed prior to commit: http://reviews.llvm.org/D17959?vs=50037&id=50717#toc Repository: rL LLVM h

Re: [PATCH] D17959: Make it possible for AST plugins to enable themselves by default

2016-03-15 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks fine to me. Repository: rL LLVM http://reviews.llvm.org/D17959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D17959: Make it possible for AST plugins to enable themselves by default

2016-03-08 Thread John Brawn via cfe-commits
john.brawn added a comment. Looking at http://reviews.llvm.org/D15729 I //think// there's no conflict between what this patch is doing and what that patch is doing. If a plugin returns AddBeforeMainAction or AddAfterMainAction then when ASTUnit in libclang loads that plugin it should get automa

Re: [PATCH] D17959: Make it possible for AST plugins to enable themselves by default

2016-03-08 Thread Manuel Klimek via cfe-commits
klimek added a reviewer: bkramer. klimek added a comment. +benjamin, who has done work in the area Repository: rL LLVM http://reviews.llvm.org/D17959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li