djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Submitted as r263470.
http://reviews.llvm.org/D17910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
djasper added a comment.
Looks good.
Comment at: lib/Format/UnwrappedLineParser.cpp:667
@@ +666,3 @@
+return true;
+ // FIXME(martinprobst): This returns true for C/C++ keywords like 'struct'.
+ return FormatTok->is(tok::identifier) &&
We don't usually put
mprobst updated this revision to Diff 50537.
mprobst added a comment.
- Handle unary !.
- Address review comments.
- Support declarations and statements in ASI.
http://reviews.llvm.org/D17910
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/Forma
mprobst added inline comments.
Comment at: unittests/Format/FormatTestJS.cpp:56
@@ +55,3 @@
+
+ static void verifyFormatNoMessup(
+ llvm::StringRef Code,
djasper wrote:
> I don't think it is useful to do this as there are always ways in which
> formatting c
mprobst updated this revision to Diff 49922.
mprobst marked 6 inline comments as done.
mprobst added a comment.
- Handle unary !.
- Address review comments.
http://reviews.llvm.org/D17910
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTes
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:665
@@ +664,3 @@
+// well known cases. It *must not* return true in speculative cases.
+bool UnwrappedLineParser::shouldInsertSemiBetween(FormatToken *Previous,
+
mprobst updated this revision to Diff 49883.
mprobst added a comment.
- Handle unary !.
http://reviews.llvm.org/D17910
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
