Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

2016-04-30 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. Committed as SVN r268167. Thanks for the patch! http://reviews.llvm.org/D17841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

2016-04-28 Thread Hanson Wang via cfe-commits
hansonw added a comment. Thanks! I don't have commit permissions; could you check this in for me? Comment at: bindings/python/clang/cindex.py:369 @@ +368,3 @@ +def __len__(self): +return int(conf.lib.clang_getNumDiagnosticsInSet(self.diag_set)) + ---

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

2016-04-28 Thread Saleem Abdulrasool via cfe-commits
compnerd accepted this revision. This revision is now accepted and ready to land. Comment at: bindings/python/clang/cindex.py:369 @@ +368,3 @@ +def __len__(self): +return int(conf.lib.clang_getNumDiagnosticsInSet(self.diag_set)) + Why

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

2016-04-27 Thread Hanson Wang via cfe-commits
hansonw added reviewers: compnerd, skalinichev. hansonw added a comment. Adding you guys since you reviewed some recent changes :) http://reviews.llvm.org/D17841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

2016-04-27 Thread Hanson Wang via cfe-commits
hansonw updated this revision to Diff 55378. hansonw added a comment. Rebase http://reviews.llvm.org/D17841 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_diagnostics.py Index: bindings/python/tests/cindex/test_diagnostics.py ==