Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

2016-03-19 Thread Chaoren Lin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263766: Remove usage of LLVM_PREFIX. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D17784?vs=50993&id=50994#toc Repository: rL LLVM http://reviews.llvm.org/D17784 Files:

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

2016-03-18 Thread Chaoren Lin via cfe-commits
chaoren updated this revision to Diff 50993. chaoren added a comment. Remove usage of LLVM_PREFIX altogether. http://reviews.llvm.org/D17784 Files: lib/Driver/ToolChains.cpp Index: lib/Driver/ToolChains.cpp === --- lib/Driver/To

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

2016-03-03 Thread Chandler Carruth via cfe-commits
chandlerc added a comment. In http://reviews.llvm.org/D17784#367601, @kparzysz wrote: > This seemed fine to me, but at the second thought, the lines 2610-2613 in the > original should be removed. I agree. I think using LLVM_PREFIX here in any capacity is incorrect. http://reviews.llvm.org/D1

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

2016-03-03 Thread Krzysztof Parzyszek via cfe-commits
kparzysz added a comment. This seemed fine to me, but at the second thought, the lines 2610-2613 in the original should be removed. http://reviews.llvm.org/D17784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

2016-03-03 Thread Krzysztof Parzyszek via cfe-commits
kparzysz added a comment. This seemed fine to me, but at the second thought, the lines 2610-2613 in the original should be removed. http://reviews.llvm.org/D17784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin