kzhuravl-AMD abandoned this revision.
kzhuravl-AMD added a comment.
After recent discussions we decided to use target specific options instead
http://reviews.llvm.org/D17764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Attribute side of things LGTM, but I don't have the expertise to comment on the
OpenCL functionality itself.
http://reviews.llvm.org/D17764
__
kzhuravl-AMD marked an inline comment as done.
kzhuravl-AMD added a comment.
http://reviews.llvm.org/D17764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kzhuravl-AMD updated this revision to Diff 50067.
kzhuravl-AMD added a comment.
Aaron's Review Comments
http://reviews.llvm.org/D17764
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeG
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5653
@@ -5655,1 +5652,3 @@
D->setInvalidDecl();
+} else if (Attr *A = D->getAttr()) {
+ Diag(D->getLocation(), diag::err_attribute_wrong_decl_type)
All of these should call
kzhuravl-AMD updated this revision to Diff 49990.
kzhuravl-AMD added a comment.
Review Feedback - Updated diff
http://reviews.llvm.org/D17764
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
li
kzhuravl-AMD marked 2 inline comments as done.
kzhuravl-AMD added a comment.
http://reviews.llvm.org/D17764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellarAMD added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:969-973
@@ +968,7 @@
+
+Clang supports the ``__attribute__((amdgpu_tools_num_reserved_vgpr()))``
+attribute on AMD Southern Islands GPUs and later. If specified, it causes AMD
+GPU Backend to reserve ``
arsenm added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1601
@@ +1600,3 @@
+if (CodeGenOpts.AMDGPUToolsInsertNopsOpt)
+ FuncAttrs.addAttribute("amdgpu_tools_insert_nops");
+if (CodeGenOpts.AMDGPUToolsNumReservedVGPROpt)
Yes
http://reviews.l
kzhuravl-AMD updated this revision to Diff 49652.
kzhuravl-AMD added a comment.
Review Feedback - Updated diff
http://reviews.llvm.org/D17764
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
li
kzhuravl-AMD marked 10 inline comments as done.
kzhuravl-AMD added a comment.
Review Feedback
Comment at: include/clang/Basic/Attr.td:993-998
@@ +992,8 @@
+
+def AMDGPUToolsInsertNops : InheritableAttr {
+ let Spellings = [GNU<"amdgpu_tools_insert_nops">];
+ let Documentation
aaron.ballman added a comment.
Some quick thoughts below.
Comment at: include/clang/Basic/Attr.td:997
@@ +996,3 @@
+ let Subjects = SubjectList<[Function], ErrorDiag,
+ "ExpectedKernelFunction">;
+}
I don't see any code that checks w
arsenm added inline comments.
Comment at: include/clang/Basic/Attr.td:993-998
@@ +992,8 @@
+
+def AMDGPUToolsInsertNops : InheritableAttr {
+ let Spellings = [GNU<"amdgpu_tools_insert_nops">];
+ let Documentation = [AMDGPUToolsInsertNopsDocs];
+ let Subjects = SubjectList<[Func
13 matches
Mail list logo
