Re: [PATCH] D17575: Determine if there's a getDecl member function using less hacks

2016-02-25 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r261872. http://reviews.llvm.org/D17575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17575: Determine if there's a getDecl member function using less hacks

2016-02-24 Thread Aaron Ballman via cfe-commits
On Wed, Feb 24, 2016 at 4:14 PM, Samuel Benzaquen via cfe-commits wrote: > sbenza added a comment. > > I assume you checked that the new trait works on MSVC. Yes. It's also used in ThreadSafety.cpp, so maybe at some point we may want to consider generalizing the trait. > Aren't both the same typ

Re: [PATCH] D17575: Determine if there's a getDecl member function using less hacks

2016-02-24 Thread Samuel Benzaquen via cfe-commits
sbenza added a comment. I assume you checked that the new trait works on MSVC. Aren't both the same type of expression SFINAE? Is somehow one supported but not the other? http://reviews.llvm.org/D17575 ___ cfe-commits mailing list cfe-commits@lists