Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-04-12 Thread Yaxun Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266117: Pass -backend-option to LLVM when there is no target machine. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D17552?vs=51326&id=53449#toc Repository: rL LLVM http://r

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-03-29 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. Ping. Tom, are you OK with this fix? http://reviews.llvm.org/D17552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-03-22 Thread Yaxun Liu via cfe-commits
yaxunl updated this revision to Diff 51326. yaxunl marked an inline comment as done. yaxunl added a comment. Add -x cl to the test when compiling it for spir target. http://reviews.llvm.org/D17552 Files: lib/CodeGen/BackendUtil.cpp test/Frontend/backend-option.c Index: test/Frontend/backen

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-03-22 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/Frontend/backend-option.c:2 @@ +1,3 @@ +// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 | FileCheck %s +// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - -triple spir-unknown-unknown 2>&1

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-03-22 Thread Yaxun Liu via cfe-commits
yaxunl marked an inline comment as done. Comment at: test/Frontend/backend-option.c:2 @@ +1,3 @@ +// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 | FileCheck %s +// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - -triple spir-unknown-unkno

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-03-22 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. LGTM, apart from small remark on the test! Comment at: test/Frontend/backend-option.c:2 @@ +1,3 @@ +// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 | FileCheck %s +// RUN: %clang_cc1 %s -emit-l

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-03-19 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-03-03 Thread Yaxun Liu via cfe-commits
yaxunl updated the summary for this revision. yaxunl added a reviewer: tstellarAMD. yaxunl removed a subscriber: tstellarAMD. yaxunl updated this revision to Diff 49781. yaxunl added a comment. Add a test for -backend-option with and w/o target machine as suggested by Tom. http://reviews.llvm.or

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-03-03 Thread Tom Stellard via cfe-commits
tstellarAMD added a comment. Do you have a test case for this? http://reviews.llvm.org/D17552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

2016-02-26 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. Hi Anastasia/Richard, I found this issue when investigating some codegen issues in Clang -cc1 with -emit-llvm. I need to pass an llvm option -print-after-all to the LLVM pass manager which is used to run the optimization passes before emitting llvm. However it did not w