Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-03-09 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r263027. http://reviews.llvm.org/D17446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-03-09 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! http://reviews.llvm.org/D17446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-03-09 Thread Aleksei Sidorin via cfe-commits
a.sidorin updated this revision to Diff 50119. a.sidorin added a comment. Improved doxygen comments. http://reviews.llvm.org/D17446 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/Dynamic/Re

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-03-07 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: docs/LibASTMatchersReference.html:512 @@ +511,3 @@ +MatcherStmt>addrLabelExprMatcherAddrLabelExpr>... +Matche

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-03-03 Thread Aleksei Sidorin via cfe-commits
a.sidorin updated this revision to Diff 49727. a.sidorin marked 15 inline comments as done. a.sidorin added a comment. Add more comments; resolve issues pointed on review. http://reviews.llvm.org/D17446 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h inclu

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-02-22 Thread Richard via cfe-commits
LegalizeAdulthood added a subscriber: LegalizeAdulthood. Comment at: docs/LibASTMatchersReference.html:512 @@ +511,3 @@ +MatcherStmt>addrLabelExprMatcherAddrL

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-02-22 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:1000 @@ +999,3 @@ + + +/// \brief Matches implicit initializers of init list expressions. Can remove the extra newline. Comment at: include/clang/ASTMatchers

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-02-19 Thread Aleksei Sidorin via cfe-commits
a.sidorin removed rL LLVM as the repository for this revision. a.sidorin updated this revision to Diff 48503. a.sidorin added a comment. Fix issues pointed by Aaron. http://reviews.llvm.org/D17446 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h include/cla

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

2016-02-19 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Given the wide disparity of functionality, I'm wondering if there are concrete purposes for these new matchers? Comment at: include/clang/ASTMatchers/ASTMatchers.h:1599 @@ -1543,1 +1598,3 @@ +/// \brief Matches atomic builtins. +const internal::