djasper closed this revision.
djasper added a comment.
Submitted as r264055.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst added a comment.
I've asked for it, but don't have it yet. Feel free to commit on by behalf.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Do you have commit access now?
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
mprobst marked 3 inline comments as done.
mprobst added a comment.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst updated this revision to Diff 51269.
mprobst added a comment.
- Address review comments:
- Add one more explanatory comment.
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/Form
mprobst updated this revision to Diff 51268.
mprobst added a comment.
Rebase diff on current master.
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
mprobst marked an inline comment as done.
Comment at: lib/Format/TokenAnnotator.cpp:760
@@ +759,3 @@
+ if (CurrentToken->is(tok::kw_export)) {
+// Find the 'from' part of export {...} from '...';
+// The difference here is that "export {...};" should not be tr
mprobst updated this revision to Diff 51267.
mprobst marked an inline comment as done.
mprobst added a comment.
- Address review comments:
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Forma
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:760
@@ +759,3 @@
+ if (CurrentToken->is(tok::kw_export)) {
+// Find the 'from' part of export {...} from '...';
+// The difference here is that "export {...};" should not be treated as
--
mprobst marked an inline comment as done.
mprobst added a comment.
As discussed offline, this matches existing very similar behaviour for
destructured goog.require calls:
js
const {X, Y, Z} = goog.require('a'); // won't ever wrap
import {X, Y, Z} from 'a'; // Shouldn't ever wrap
It also
djasper added a comment.
I am missing a decent explanation here. In contrast to C++ #includes as well as
goog.require, etc. The import/export statements actually provide syntactic
structure and can name multiple entities. Why would it be a good idea to always
write them into a single line?
==
mprobst added a comment.
FYI this should not be submitted yet, there are still style discussions going
on.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
12 matches
Mail list logo
