Re: [PATCH] D17387: Add check for CERT FLP30-C

2016-02-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. LG Comment at: test/clang-tidy/cert-flp30-c.c:6 @@ +5,3 @@ +void func(void) { + // CHECK-MESSAGES: :[[@LINE+1]]:37: warning: loop induction expression should not have floating-point type [cert-flp30-c] + for (float x = 0.1f; x <= 1.0f; x += 0.1f) { ---

Re: [PATCH] D17387: Add check for CERT FLP30-C

2016-02-19 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Thanks! I've commit in r261324. Comment at: test/clang-tidy/cert-flp30-c.c:6 @@ +5,3 @@ +void func(void) { + // CHECK-MESSAGES: :[[@LINE+1]]:37: warning: loop indu

Re: [PATCH] D17387: Add check for CERT FLP30-C

2016-02-19 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM with one nit. Comment at: test/clang-tidy/cert-flp30-c.c:6 @@ +5,3 @@ +void func(void) { + // CHECK-MESSAGES: :[[@LINE+1]]:37: warning: loop induction expression should