Re: [PATCH] D17367: [OpenMP] Code generation for target data directive

2016-04-27 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 55347. sfantao added a comment. - Rebase. http://reviews.llvm.org/D17367 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/target_data_codegen.cpp Index: test/OpenMP/target_data_codegen.cp

Re: [PATCH] D17367: [OpenMP] Code generation for target data directive

2016-02-26 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 49244. sfantao marked 2 inline comments as done. sfantao added a comment. Remove extra braces. Waiting on dependency. http://reviews.llvm.org/D17367 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp t

Re: [PATCH] D17367: [OpenMP] Code generation for target data directive

2016-02-25 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2736-2738 @@ +2735,5 @@ + const Expr *IfCond = nullptr; + if (auto *C = S.getSingleClause()) { +IfCond = C->getCondition();

Re: [PATCH] D17367: [OpenMP] Code generation for target data directive

2016-02-23 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 48831. sfantao updated the summary for this revision. sfantao added a comment. Rebase. http://reviews.llvm.org/D17367 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/target_data_codegen.c