This revision was automatically updated to reflect the committed changes.
jyknight marked an inline comment as done.
Closed by commit rL262737: Make TargetInfo store an actual DataLayout instead
of a string. (authored by jyknight).
Changed prior to commit:
http://reviews.llvm.org/D17183?vs=4776
rafael added a subscriber: rafael.
rafael added a comment.
This is awesome!
Comment at: include/clang/CodeGen/BackendUtil.h:38
@@ -37,3 +37,3 @@
const TargetOptions &TOpts, const LangOptions &LOpts,
- StringRef TDesc, llvm::Modul
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sorry, I've been waffling on this, but I think this is fine.
Thanks!
-eric
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-
jyknight added a comment.
Ping. I'm pretty sure you said you were going to look at this. :)
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
In http://reviews.llvm.org/D17183#351361, @jyknight wrote:
> Those changes were necessary due to a name (IIRC it was "Module") existing
> in both the clang and llvm namespaces, and after this change, becoming
> ambiguous in those files.
Ah, that one. Okay.
http://
Those changes were necessary due to a name (IIRC it was "Module") existing
in both the clang and llvm namespaces, and after this change, becoming
ambiguous in those files.
On Feb 12, 2016 3:16 AM, "Paul Robinson"
wrote:
> probinson added a subscriber: probinson.
> probinson added a comment.
>
> D
probinson added a subscriber: probinson.
probinson added a comment.
Driveby comment: the changes in unittests look unrelated?
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
jyknight added a comment.
In http://reviews.llvm.org/D17183#351065, @yaron.keren wrote:
> We have tried to keep one copy of DataLayout around
> http://reviews.llvm.org/D11103
> Can it share the Module->getDataLayout() ?
We're at the beginning of clang here, before preprocessing. There's no
l
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
We have tried to keep one copy of http://reviews.llvm.org/D11103
Can it share the Module->getDataLayout() ?
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-com
