carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 262652.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
carlo.bertolli added a comment.
Thanks - waiting for dependence http://reviews.llvm.org/D17019 before commit.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
carlo.bertolli updated this revision to Diff 48511.
carlo.bertolli added a comment.
Update against trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/teams_codegen.cpp
carlo.bertolli updated this revision to Diff 48369.
carlo.bertolli added a comment.
Addressed latest comments.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/teams_codege
carlo.bertolli marked 4 inline comments as done.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431
@@ +4425,8 @@
+ SourceLocation Loc) {
+ llvm::Value *PushNumTeamsArgs[] = {
+ emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc), N
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431
@@ +4425,8 @@
+ SourceLocation Loc) {
+ llvm::Value *PushNumTeamsArgs[] = {
+ emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc), NumTeams,
+ Th
carlo.bertolli updated this revision to Diff 48271.
carlo.bertolli added a comment.
Update against dependence http://reviews.llvm.org/D17019.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP
carlo.bertolli set the repository for this revision to rL LLVM.
carlo.bertolli updated this revision to Diff 47995.
carlo.bertolli added a comment.
Added comment for boolean parameter.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/C
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
I updated the patch to reflect the comments. I will wait for an answer to the
comment asking to split the emit function for push_num_teams. Thanks!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:1009-10
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:1009-1015
@@ +1008,9 @@
+
+ /// \brief Emits call to void __kmpc_push_num_teamss(ident_t *loc, kmp_int32
+ /// global_tid, kmp_int32 num_teams, kmp_int32 thread_limit) to generate code
+ /// for num_teams
carlo.bertolli updated this revision to Diff 47890.
carlo.bertolli added a comment.
Apply changes to reflect review: have a single emit outlined function call for
both parallel and teams; call push_num_teams outside of runtime class.
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMP
carlo.bertolli marked 2 inline comments as done.
carlo.bertolli added a comment.
I applied your suggestions and generated a new diff file.
Thanks!
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4378-4398
@@ +4377,23 @@
+
+ const OMPNumTeamsClause *NT = TD.getSingleClause();
+ const OMPThreadLimitClause *TL = TD.getSingleClause();
+ if (NT || TL) {
+NumTeamsVal = (NT) ? CGF.EmitScalarExpr(NT
carlo.bertolli removed rL LLVM as the repository for this revision.
carlo.bertolli updated this revision to Diff 47695.
carlo.bertolli added a comment.
Remove handling of reductions - not supported by this patch.
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/Code
15 matches
Mail list logo
