Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Eric Christopher via cfe-commits
echristo added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); tra wrote: >

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Artem Belevich via cfe-commits
tra added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); hfinkel wrote: > e

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Hal Finkel via cfe-commits
hfinkel added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); echristo wrote

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Eric Christopher via cfe-commits
echristo added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); tra wrote: >

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Artem Belevich via cfe-commits
tra added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); tra wrote: > hfink

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Artem Belevich via cfe-commits
tra added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); hfinkel wrote: > e

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Hal Finkel via cfe-commits
hfinkel added a subscriber: hfinkel. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); echristo

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Eric Christopher via cfe-commits
echristo added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); jlebar wrote:

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Wow really? That's ... wow. OK http://reviews.llvm.org/D17111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

2016-02-10 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); I think this is