Re: [PATCH] D16970: scoped alloc construct: adds basic tests

2016-02-07 Thread Masud Rahman via cfe-commits
frutiger updated this revision to Diff 47143. frutiger added a comment. Fixes include guards. http://reviews.llvm.org/D16970 Files: test/std/utilities/allocator.adaptor/scoped.adaptor.operators/construct.pass.cpp test/support/instrumentingallocators.h Index: test/support/instrumentingallo

Re: [PATCH] D16970: scoped alloc construct: adds basic tests

2016-02-07 Thread Alisdair Meredith via cfe-commits
AlisdairM added a subscriber: AlisdairM. Comment at: test/support/instrumentingallocators.h:25 @@ +24,3 @@ +~Instrumentation() { +assert(allocs_.empty()); +} Perhaps a loop, showing what leaked? for (auto const& alloc : allocs_) { std::cout <<

Re: [PATCH] D16970: scoped alloc construct: adds basic tests

2016-02-07 Thread Masud Rahman via cfe-commits
frutiger updated this revision to Diff 47141. frutiger added a comment. Added `operator==` and `operator!=`. http://reviews.llvm.org/D16970 Files: test/std/utilities/allocator.adaptor/scoped.adaptor.operators/construct.pass.cpp test/support/instrumentingallocators.h Index: test/support/in