This revision was automatically updated to reflect the committed changes.
Closed by commit rL269201: Update clang support on recent Haiku (authored by
rnk).
Changed prior to commit:
http://reviews.llvm.org/D16797?vs=53464&id=56929#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16797
File
korli added a comment.
Ping?
Repository:
rL LLVM
http://reviews.llvm.org/D16797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
korli updated this revision to Diff 53464.
korli added a comment.
Updated patch against trunk (following changes in lib/Basic/Targets.cpp).
Repository:
rL LLVM
http://reviews.llvm.org/D16797
Files:
lib/Basic/Targets.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolC
korli removed rL LLVM as the repository for this revision.
korli updated this revision to Diff 52953.
korli added a comment.
Thanks for the review, and sorry for the late reply.
This updated diff takes rsmith's comments into account, adding a test
test/Driver/haiku.c, a case for CST_Libcxx where
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
Please rebase against trunk. I'm surprised that no tests need updating due to
this. Can you add some, please?
Comment at: lib/Basic/Targets.cpp:387
@@ +386,3 @@
+
korli added a comment.
Yes, I don't have commit access.
Repository:
rL LLVM
http://reviews.llvm.org/D16797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
Do you need someone to commit this for you?
Repository:
rL LLVM
http://reviews.llvm.org/D16797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
korli updated this revision to Diff 51571.
korli added a comment.
This updated diff fixes the x86-32 Haiku target, which needs the target define
__INTEL__.
This applies directly to today's trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D16797
Files:
lib/Basic/Targets.cpp
lib/Driver/
rjmccall added a comment.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D16797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
korli added a comment.
Ping?
Repository:
rL LLVM
http://reviews.llvm.org/D16797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
10 matches
Mail list logo