ariccio marked an inline comment as done.
ariccio added a comment.
Grr! missed a single note.
http://reviews.llvm.org/D16748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio added a comment.
In http://reviews.llvm.org/D16748#343011, @aaron.ballman wrote:
> LGTM, but the patch does not apply cleanly because it was created using
> absolute paths. In the future, please generate the patch with relative paths.
> ;-)
>
> Commit in r259652
Oops.
http://reviews
aaron.ballman closed this revision.
aaron.ballman added a comment.
LGTM, but the patch does not apply cleanly because it was created using
absolute paths. In the future, please generate the patch with relative paths.
;-)
Commit in r259652
http://reviews.llvm.org/D16748
ariccio added a comment.
All set.
http://reviews.llvm.org/D16748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio updated this revision to Diff 46737.
ariccio marked 2 inline comments as done.
ariccio added a comment.
Removed single `const`.
http://reviews.llvm.org/D16748
Files:
C:/LLVM/llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
C:/LLVM/llvm/tools/clang/lib/St
ariccio marked 3 inline comments as done.
ariccio added a comment.
I will remove that `const` later tonight.
Comment at: C:/LLVM/llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1396
@@ -1395,3 +1395,3 @@
const auto &ReferencedBlockVars = AC->getReferencedBlockVars(BC->
aaron.ballman added inline comments.
Comment at: C:/LLVM/llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1396
@@ -1395,3 +1395,3 @@
const auto &ReferencedBlockVars = AC->getReferencedBlockVars(BC->getDecl());
- auto NumBlockVars =
+ const auto NumBlockVars =
std
ariccio marked an inline comment as done.
ariccio added a comment.
As said in comment, I disagree with the no need for `const` here.
Comment at: C:/LLVM/llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1396
@@ -1395,3 +1395,3 @@
const auto &ReferencedBlockVars = AC->get
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from one minor nit with `auto` usage, LGTM!
Comment at: C:/LLVM/llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1396
@@ -1395,3 +1395,3 @@
const
ariccio updated this revision to Diff 46481.
ariccio marked 10 inline comments as done.
ariccio added a comment.
Removed extra spaces.
http://reviews.llvm.org/D16748
Files:
C:/LLVM/llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
C:/LLVM/llvm/tools/clang/lib/Sta
ariccio added a comment.
Oops. The funny thing about the extra spaces is that I wasn't sure why there
were spaces after the casts already, so I figured that I should keep it that
way.
I shall fix.
http://reviews.llvm.org/D16748
___
cfe-commits m
dcoughlin added a subscriber: cfe-commits.
dcoughlin added a comment.
Also adding cfe-commits as a subscriber. (See
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).
http://reviews.llvm.org/D16748
___
cfe-commits mai
12 matches
Mail list logo
