Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-03-21 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263947: clang-cl: support __cdecl-on-struct anachronism (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D16628?vs=46228&id=51176#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-03-21 Thread Stephan Bergmann via cfe-commits
sberg added a comment. friendly ping http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-03-03 Thread Stephan Bergmann via cfe-commits
sberg added a comment. Can you please push this, I do not have commit access. Thanks http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-03-02 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-03-02 Thread Stephan Bergmann via cfe-commits
sberg added a comment. friendly ping http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-01-27 Thread Stephan Bergmann via cfe-commits
sberg updated this revision to Diff 46228. sberg added a comment. updated as discussed in the comments http://reviews.llvm.org/D16628 Files: lib/Parse/ParseDeclCXX.cpp test/Parser/ms-anachronism.c Index: test/Parser/ms-anachronism.c =

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-01-27 Thread David Majnemer via cfe-commits
majnemer added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:1107 @@ +1106,3 @@ + // Microsoft compatibility + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) sberg wrote: > majnemer wrote:

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-01-27 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. Comment at: lib/Parse/ParseDeclCXX.cpp:1107 @@ +1106,3 @@ + // Microsoft compatibility + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) What about __fastcall, e

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-01-27 Thread Stephan Bergmann via cfe-commits
sberg added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:1107 @@ +1106,3 @@ + // Microsoft compatibility + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) majnemer wrote: > What about __fas

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-01-27 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:1108-1110 @@ -1106,1 +1107,5 @@ + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) + break; +// fall through // Type qualifiers -