alexfh added a comment.
Thank you for the fix! Committed as r258801.
Repository:
rL LLVM
http://reviews.llvm.org/D16536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258801: Fix crashing on user-defined conversion. (authored
by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D16536?vs=45873&id=45963#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1653
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D16536
___
cfe-commits mailing list
cfe-com
congliu added inline comments.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:175
@@ +174,3 @@
+/// operator TypeName()
+static bool isUserDefinedConversion(const CXXMethodDecl *MD) {
+ return StringRef(MD->getNameAsString()).find(StringRef("operator ")) !=
--
congliu updated this revision to Diff 45873.
congliu added a comment.
- Address the comment and clean up the code.
http://reviews.llvm.org/D16536
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
test/clang-tidy/misc-virtual-near-miss.cpp
Index: test/clang-tidy/misc-virtual-near-miss.cpp
===
aaron.ballman added a subscriber: aaron.ballman.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:175
@@ +174,3 @@
+/// operator TypeName()
+static bool isUserDefinedConversion(const CXXMethodDecl *MD) {
+ return StringRef(MD->getNameAsString()).find(StringRef("operator "))
