Re: [PATCH] D16511: [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Ehsan Akhgari via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258720: [MSVC Compat] Only warn for unknown clang-cl arguments (authored by ehsan). Changed prior to commit: http://reviews.llvm.org/D16511?vs=45796&id=45906#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D16511: [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Ehsan Akhgari via cfe-commits
Thanks for the reviews! Will address both when landing. On Mon, Jan 25, 2016 at 2:34 PM, Hans Wennborg wrote: > hans added a subscriber: hans. > hans added a comment. > > Maybe this behavior should be called out in the Command-Line Options > section under clang-cl in docs/UsersManual.rst? > > >

Re: [PATCH] D16511: [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Hans Wennborg via cfe-commits
hans added a subscriber: hans. hans added a comment. Maybe this behavior should be called out in the Command-Line Options section under clang-cl in docs/UsersManual.rst? http://reviews.llvm.org/D16511 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D16511: [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm other than the warning group. Comment at: test/Misc/warning-flags.c:21 @@ -20,3 +20,3 @@ -CHECK: Warnings without flags (84): +CHECK: Warnings without flags (85): CHECK-NEXT