Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-26 Thread Eric Baker via cfe-commits
ebaker355 reclaimed this revision. ebaker355 added a comment. Ok, cool! :) Thanks! http://reviews.llvm.org/D16066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-26 Thread Daniel Jasper via cfe-commits
djasper added a comment. Feel free to leave this patch around. Maybe somebody else comes up with something that meets the other criteria ;-). Me personally, I just think that seeing "while (1);" on a single line is quite misleading. But maybe that is just me. http://reviews.llvm.org/D16066

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-26 Thread Eric Baker via cfe-commits
ebaker355 abandoned this revision. ebaker355 added a comment. Since I cannot meet these criteria: - be used in a project of significant size (have dozens of contributors) - have a publicly accessible style guide I will abandon this revision request. Thank you for considering! http://reviews.ll

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-26 Thread Eric Baker via cfe-commits
ebaker355 added a comment. Thanks for responding, and for the documentation link! It is certainly wise to not attempt "to supporting every single style used by a codebase somewhere in the wild." I do not know of a predefined coding style that recommends this format. My thinking was: - it comp

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-26 Thread Daniel Jasper via cfe-commits
djasper added a comment. Is there a coding style that actually recommends this? I would be quite doubtful that it is a good idea as it makes those loops harder to distinguish from other while loops. Generally, there is a certain bar to getting additional style flags into clang-format: http://cl

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-25 Thread Eric Baker via cfe-commits
ebaker355 added a comment. Ping. Anyone have an opinion on this? http://reviews.llvm.org/D16066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits