jlebar accepted this revision.
jlebar added a reviewer: jlebar.
jlebar added a comment.
This revision is now accepted and ready to land.
Pushed in r257808 with echristo's lg (sorry, didn't have the right metadata in
the commit).
http://reviews.llvm.org/D15960
jlebar added a comment.
In http://reviews.llvm.org/D15960#324162, @echristo wrote:
> So, how are you getting to the point where you're trying to create the same
> action twice?
>
> -eric
In the new CUDA world, we have the following graph, which I hope will render
properly:
foo.cu --> foo.s
jlebar added a comment.
In http://reviews.llvm.org/D15960#324162, @echristo wrote:
> So, how are you getting to the point where you're trying to create the same
> action twice?
>
> -eric
In the new CUDA world, we have the following graph, which I hope will render
properly:
foo.cu --> foo.s
echristo added a comment.
So, how are you getting to the point where you're trying to create the same
action twice?
-eric
http://reviews.llvm.org/D15960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
jlebar added a comment.
OK, this is now working, please have a look. I'm not sure if it's possible to
write a test as-is, but I have a test for my mistake in my WIP CUDA patch.
(Also this mistake is much harder to make after http://reviews.llvm.org/D16013.)
http://reviews.llvm.org/D15960
jlebar updated this revision to Diff 44377.
jlebar added a dependency: D16013: Make Driver::BuildJobsForAction return an
InputInfo, instead of using an outparam..
jlebar added a comment.
Fixing bug caused by missing an outparam.
Covered by tests in WIP CUDA+ptxas+fatbin patch.
Depends on http:/
jlebar added a comment.
This actually has a subtle issue not found with existing unit tests:
BuildJobsForAction has an outparam and we don't set it on cache hit.
Please hold off reviewing this until I fix the problem.
http://reviews.llvm.org/D15960
__
