Re: [PATCH] D15935: Improve diagnostics for literal conversion to Boolean

2016-02-15 Thread Aaron Ballman via cfe-commits
aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Ping http://reviews.llvm.org/D15935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15935: Improve diagnostics for literal conversion to Boolean

2016-01-23 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:6985 @@ -6984,6 +6984,3 @@ SmallString<16> PrettyTargetValue; - if (T->isSpecificBuiltinType(BuiltinType::Bool)) -PrettyTargetValue = Value.isZero() ? "false" : "true"; - else -IntegerValue.toS

Re: [PATCH] D15935: Improve diagnostics for literal conversion to Boolean

2016-01-21 Thread Manman Ren via cfe-commits
manmanren added a subscriber: manmanren. manmanren added a comment. Thanks for working on this. This looks good to me overall, but I am not the expert on Sema :] Cheers, Manman Comment at: lib/Sema/SemaChecking.cpp:6985 @@ -6984,6 +6984,3 @@ SmallString<16> PrettyTargetValu

Re: [PATCH] D15935: Improve diagnostics for literal conversion to Boolean

2016-01-20 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Ping http://reviews.llvm.org/D15935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits