Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-27 Thread George Burgess IV via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259011: [Sema] Make extended vectors of `bool` an error. (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D15721?vs=46088&id=46205#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-27 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Seems sensible. LGTM! http://reviews.llvm.org/D15721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-26 Thread George Burgess IV via cfe-commits
george.burgess.iv added a reviewer: hfinkel. george.burgess.iv updated this revision to Diff 46088. george.burgess.iv added a comment. +hfinkel as a reviewer, because `git` said he originally added the tests I'm removing. I played around a bit, and it turns out that we don't generate correct mac

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-26 Thread George Burgess IV via cfe-commits
george.burgess.iv added a comment. > I think we will also need to forbid the invalid conversions too at some point. test/SemaOpenCL/vector_conv_invalid.cl checks that clang gives you errors converting e.g. a `4 x unsigned` to a `4 x int`. So, unless you were referring to something else, that s

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-26 Thread George Burgess IV via cfe-commits
george.burgess.iv updated this revision to Diff 46053. george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. Updated comment, as requested. http://reviews.llvm.org/D15721 Files: lib/Sema/SemaExpr.cpp lib/Sema/SemaType.cpp test/CodeGen/bool-vector-conversio

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-26 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. OpenCL side seems fine! Thanks for adding OpenCL diagnostic btw. I think we will also need to forbid the invalid conversions too at some point. Comment at: lib/Sema/SemaExpr.cpp:5715 @@ +5714,3 @@ + // when compiling code as e.g. C++) + uint64_t src

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-25 Thread George Burgess IV via cfe-commits
george.burgess.iv added a comment. > I am generally not clear about the scope of this patch. Is it intended for > OpenCL or C++? Sorry for the lack of clarity; I was mildly confused about what parts of the OpenCL spec apply to extended vectors when compiling code as C/C++. I think I have a be

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-25 Thread George Burgess IV via cfe-commits
george.burgess.iv updated this revision to Diff 45930. george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. - Added diagnostics that prohibit vectors of booleans in OpenCL - Added tests for extended vectors of bools in C (previously existed only in C++) - Clarifi

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-25 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. I am generally not clear about the scope of this patch. Is it intended for OpenCL or C++? As for OpenCL, boolean vector types are not permitted (Table 6.2). Also conversions between vector types are disallowed in general (Section 6.2.2) but unfortunately Clang doesn'

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-20 Thread George Burgess IV via cfe-commits
george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D15721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-12 Thread George Burgess IV via cfe-commits
george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D15721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-04 Thread George Burgess IV via cfe-commits
george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D15721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

2016-01-04 Thread George Burgess IV via cfe-commits
george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D15721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits