Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2016-02-01 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259453: [asan] Add iOS support for Address Sanitizer (authored by zaks). Changed prior to commit: http://reviews.llvm.org/D15624?vs=45720&id=46605#toc Repository: rL LLVM http://reviews.llvm.org/D15

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2016-01-22 Thread Alexey Samsonov via cfe-commits
samsonov accepted this revision. samsonov added a reviewer: samsonov. samsonov added a comment. LGTM Comment at: lib/Driver/ToolChains.cpp:339 @@ +338,3 @@ + } +} + You might need `llvm_unreachable` at the very end to suppress GCC warnings (http://llvm.org/doc

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2016-01-22 Thread Anna Zaks via cfe-commits
zaks.anna updated this revision to Diff 45720. zaks.anna added a comment. Thanks for spotting the bug! The bug is fixed and the tests are added in this revision. http://reviews.llvm.org/D15624 Files: lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h test/Driver/darwin-sanitizer-ld.c te

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2016-01-21 Thread Alexey Samsonov via cfe-commits
samsonov added a comment. Thanks. Comment at: lib/Driver/ToolChains.cpp:322 @@ -321,1 +321,3 @@ +StringRef Darwin::getOSLibraryNameSuffix() const { + if (isTargetMacOS()) Fun fact: if TargetPlatform is `TvOSSimulator`, this function will return `iossim` beca

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2016-01-20 Thread Anna Zaks via cfe-commits
zaks.anna marked an inline comment as done. zaks.anna added a comment. I've introduced the helper function. Looks like addProfileRTLibs might be able to use it in the future (after support for autoconf is dropped) as well. http://reviews.llvm.org/D15624 __

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2016-01-20 Thread Anna Zaks via cfe-commits
zaks.anna updated this revision to Diff 45437. zaks.anna added a comment. Refactor the code to address Samsonov's review. http://reviews.llvm.org/D15624 Files: lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h test/Driver/fsanitize.c Index: test/Driver/fsanitize.c ===

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2016-01-11 Thread Alexey Samsonov via cfe-commits
samsonov added a comment. Sorry, lost track of this. Comment at: lib/Driver/ToolChains.cpp:368 @@ +367,3 @@ + StringRef OS = ""; + if (isTargetMacOS()) +OS = "osx"; zaks.anna wrote: > samsonov wrote: > > Wait, this looks horrible. Can we teach toolchain to

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2015-12-17 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/Driver/ToolChains.cpp:368 @@ +367,3 @@ + StringRef OS = ""; + if (isTargetMacOS()) +OS = "osx"; samsonov wrote: > Wait, this looks horrible. Can we teach toolchain to give us OS name? These are not OS names; t

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2015-12-17 Thread Alexey Samsonov via cfe-commits
samsonov added a subscriber: samsonov. Comment at: lib/Driver/ToolChains.cpp:368 @@ +367,3 @@ + StringRef OS = ""; + if (isTargetMacOS()) +OS = "osx"; Wait, this looks horrible. Can we teach toolchain to give us OS name? http://reviews.llvm.org/D15624 _

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

2015-12-17 Thread Kostya Serebryany via cfe-commits
kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits