logan closed this revision.
logan added a comment.
Thanks! Committed as http://reviews.llvm.org/rL256241.
http://reviews.llvm.org/D15613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
echristo added a comment.
Sure, I don't care enough either way :)
-eric
http://reviews.llvm.org/D15613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
logan added a comment.
@echristo: IMO, I prefer not to add such comment for two reasons:
1. It will obscure the main idea of this piece of code.
2. It is common to specify the section flags (compilers will emit these flags
by default as well), so it is unlikely to be removed in the future.
Bes
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This works for me as a workaround, a comment about what's going on here would
probably be good.
-eric
http://reviews.llvm.org/D15613
___
cf
