Re: [PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

2015-12-10 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:3715 @@ -3741,3 +3714,3 @@ assert(D.Kind == Designator::ArrayDesignator && "Requires array designator"); - Stmt *const *SubExprs = reinterpret_cast(this + 1); + auto SubExprs = reinterpret_cast(this + 1); re

Re: [PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

2015-12-10 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added inline comments. Comment at: lib/AST/Expr.cpp:1956 @@ -1967,1 +1955,3 @@ +for (const auto &I : InitExprs) { + if (Stmt *S = I) { Beg = S->getLocStart(); aaron.ballman wrote: > Is this line still required? I thought InitExprs

Re: [PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

2015-12-10 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:67 @@ -65,3 +66,3 @@ E = CE->getSubExpr(); -CXXRecordDecl *Derived +auto *Derived = cast(E->getType()->getAs()->getDecl()); Again, I don't think it is an improvem