Re: [PATCH] D15314: Fix a bug in unavailable checking

2016-03-10 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263149: Add TreatUnavailableAsInvalid for the verification-only mode in InitListChecker. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D15314?vs=48228&id=50312#toc Repository:

Re: [PATCH] D15314: Fix a bug in unavailable checking

2016-03-09 Thread Doug Gregor via cfe-commits
doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D15314: Fix a bug in unavailable checking

2016-03-09 Thread Manman Ren via cfe-commits
manmanren added a comment. Ping http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15314: Fix a bug in unavailable checking

2016-02-17 Thread Manman Ren via cfe-commits
manmanren added a comment. Doug, Thanks for reviewing! I updated the patch to use TreatUnavailableAsInvalid. Cheers, Manman http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: [PATCH] D15314: Fix a bug in unavailable checking

2016-02-17 Thread Manman Ren via cfe-commits
manmanren updated this revision to Diff 48228. http://reviews.llvm.org/D15314 Files: include/clang/Sema/Initialization.h include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp test/SemaObjC/Inputs/arc-system-header.h test/SemaObjC/arc-system-head

Re: [PATCH] D15314: Fix a bug in unavailable checking

2016-02-16 Thread Doug Gregor via cfe-commits
doug.gregor added a comment. The approach and patch look okay to me, but can we give "UnavailableCheck" a less ambiguous name? For example, "TreatUnavailableAsInvalid"? http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D15314: Fix a bug in unavailable checking

2016-01-11 Thread Manman Ren via cfe-commits
manmanren added a comment. Ping :] http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15314: Fix a bug in unavailable checking

2015-12-17 Thread Manman Ren via cfe-commits
manmanren added a comment. Ping Appreciate comments on the general direction. Cheers, Manman http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits