bruno accepted this revision.
bruno added a reviewer: bruno.
bruno added a comment.
Thanks,
Committed r259311!
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
doug.gregor accepted this revision.
doug.gregor added a comment.
This approach looks great to me.
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 46332.
bruno added a comment.
Update the patch to use ArrayRef and remove a misleading assertion.
Richard, any more comments regarding this approach?
Thanks,
http://reviews.llvm.org/D15173
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPCaching.cpp
l
Ping!
On Wed, Jan 20, 2016 at 11:22 AM, Bruno Cardoso Lopes
wrote:
> bruno updated this revision to Diff 45421.
> bruno added a comment.
>
> Update patch after Richard comments
>
>
> http://reviews.llvm.org/D15173
>
> Files:
> include/clang/Lex/Preprocessor.h
> lib/Lex/PPCaching.cpp
> lib/P
bruno updated this revision to Diff 45421.
bruno added a comment.
Update patch after Richard comments
http://reviews.llvm.org/D15173
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPCaching.cpp
lib/Parse/ParseTemplate.cpp
test/Parser/objcxx11-protocol-in-template.mm
Index: test/Parser
Hi Richard,
>> + // The advance from '>>' to '>' in a ObjectiveC template argument list
>> needs
>> + // to be properly reflected in the token cache to allow correct
>> interaction
>> + // between annotation and backtracking.
>> + if (ObjCGenericList && PrevTok.getKind() == tok::greatergreater
On Jan 7, 2016 7:13 PM, "Bruno Cardoso Lopes"
wrote:
>
> bruno updated this revision to Diff 44306.
> bruno added a comment.
>
> Hi Richard,
>
> Thanks for the detailed explanation, it now makes sense to me. I updated
the patch with another approach! Let me know if it's the right direction.
>
>
>
Ping :-)
On Mon, Jan 11, 2016 at 8:49 AM, Bruno Cardoso Lopes
wrote:
> bruno added a comment.
>
> Ping!
>
>
> http://reviews.llvm.org/D15173
>
>
>
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
___
cfe-commits mailing list
cfe-commits@lists.llvm.
bruno added a comment.
Ping!
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 44306.
bruno added a comment.
Hi Richard,
Thanks for the detailed explanation, it now makes sense to me. I updated the
patch with another approach! Let me know if it's the right direction.
http://reviews.llvm.org/D15173
Files:
include/clang/Lex/Preprocess
On Wed, Jan 6, 2016 at 4:22 PM, Bruno Cardoso Lopes wrote:
> bruno updated this revision to Diff 44180.
> bruno added a comment.
>
> Hi Richard,
>
> Thanks for the comments. Updated the patch!
>
> In http://reviews.llvm.org/D15173#313235, @rsmith wrote:
>
> > I think that this will leave us with
bruno updated this revision to Diff 44180.
bruno added a comment.
Hi Richard,
Thanks for the comments. Updated the patch!
In http://reviews.llvm.org/D15173#313235, @rsmith wrote:
> I think that this will leave us with a broken token stream. In your example,
> the cached token stream starts as
rsmith added a subscriber: rsmith.
rsmith requested changes to this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision now requires changes to proceed.
I think that this will leave us with a broken token stream. In your example,
the cached token stream starts as
`NS
akyrtzi added a comment.
LGTM.
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LGTM.
> On Dec 12, 2015, at 5:25 PM, Bruno Cardoso Lopes
> wrote:
>
> bruno updated this revision to Diff 42649.
> bruno added a comment.
>
> Thanks Duncan and Argyrios, updated a patch with the suggestions!
>
>
> http://reviews.llvm.org/D15173
>
> Files:
> lib/Lex/PPCaching.cpp
> test/Pa
bruno added a comment.
Ping!
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 42649.
bruno added a comment.
Thanks Duncan and Argyrios, updated a patch with the suggestions!
http://reviews.llvm.org/D15173
Files:
lib/Lex/PPCaching.cpp
test/Parser/objcxx11-protocol-in-template.mm
Index: test/Parser/objcxx11-protocol-in-template.mm
=
> On 2015-Dec-07, at 14:22, Duncan P. N. Exon Smith
> wrote:
>
>
>> On 2015-Dec-07, at 13:29, Bruno Cardoso Lopes
>> wrote:
>>
>> bruno added a comment.
>>
>> Hi Argyrios,
>>
>> Thanks for the suggestions, will apply them.
>> The assertion seems important to catch subtle bugs, are you sur
> On 2015-Dec-07, at 13:29, Bruno Cardoso Lopes wrote:
>
> bruno added a comment.
>
> Hi Argyrios,
>
> Thanks for the suggestions, will apply them.
> The assertion seems important to catch subtle bugs, are you sure it should be
> placed inside a "#ifndef NDEBUG”?
FYI, the definition for `ass
bruno added a comment.
Hi Argyrios,
Thanks for the suggestions, will apply them.
The assertion seems important to catch subtle bugs, are you sure it should be
placed inside a "#ifndef NDEBUG”?
http://reviews.llvm.org/D15173
___
cfe-commits mailing
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
Hi Bruno,
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Bruno,
> On Dec 2, 2015, at 7:29 PM, Bruno Cardoso Lopes
> wrote:
>
> bruno created this revision.
> bruno added reviewers: doug.gregor, akyrtzi.
> bruno added subscribers: cfe-commits, dexonsmith.
>
> Consider the following ObjC++ snippet:
>
> @protocol PA;
> @protocol PB;
>
> @class
bruno added a comment.
Ping!
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
23 matches
Mail list logo
