davidxl added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Easwaran Raman writes:
> eraman added a comment.
>
> Justin, does this patch look ok?
Sure.
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
eraman added a comment.
Justin, does this patch look ok?
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eraman updated this revision to Diff 43089.
eraman added a comment.
Updated the test case.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/Inputs/max-function-count.proftext
test/Profile/max-function-count.c
Index: test/Profile/max-
davidxl added a comment.
I prefer using the profile from the original test case where Max count is not 1.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
eraman updated this revision to Diff 42801.
eraman added a comment.
Fix the comment in the test case
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/Inputs/max-function-count.proftext
test/Profile/max-function-count.c
Index: test/Pr
eraman updated this revision to Diff 42797.
eraman added a comment.
Updated the patch addressing Justin's comments and a new test case.
(Should I open a new review thread since phabricator thinks this has been
submitted?)
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/Code
On Mon, Dec 14, 2015 at 3:26 PM, Xinliang David Li
wrote:
> On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner
> wrote:
> > Easwaran Raman writes:
> >> eraman updated this revision to Diff 42549.
> >> eraman added a comment.
> >>
> >> Added a test case.
> >>
> >>
> >> Repository:
> >> rL LLVM
> >
On Fri, Dec 11, 2015 at 6:12 PM, Justin Bogner
wrote:
> Easwaran Raman writes:
> > eraman added a comment.
> >
> > I have reverted the commit in r255416 because the test failed in many
> > architectures.
>
> You also committed without waiting for further review, despite that
> David said "LGTM b
On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner wrote:
> Easwaran Raman writes:
>> eraman updated this revision to Diff 42549.
>> eraman added a comment.
>>
>> Added a test case.
>>
>>
>> Repository:
>> rL LLVM
>>
>> http://reviews.llvm.org/D15163
>>
>> Files:
>> lib/CodeGen/CodeGenModule.cpp
On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner wrote:
> Easwaran Raman writes:
>> eraman updated this revision to Diff 42549.
>> eraman added a comment.
>>
>> Added a test case.
>>
>>
>> Repository:
>> rL LLVM
>>
>> http://reviews.llvm.org/D15163
>>
>> Files:
>> lib/CodeGen/CodeGenModule.cpp
davidxl added inline comments.
Comment at: cfe/trunk/test/CodeGen/pgo-max-function-count.c:1
@@ +1,2 @@
+// RUN: %clang -fprofile-generate -o %t -O2 %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %t
Use -fprofile-instr-generate option. -fprofile-generate is for GCC
Easwaran Raman writes:
> eraman updated this revision to Diff 42549.
> eraman added a comment.
>
> Added a test case.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D15163
>
> Files:
> lib/CodeGen/CodeGenModule.cpp
> test/CodeGen/pgo-max-function-count.c
>
> Index: test/CodeGen/pgo-
Easwaran Raman writes:
> eraman added a comment.
>
> I have reverted the commit in r255416 because the test failed in many
> architectures.
You also committed without waiting for further review, despite that
David said "LGTM but please wait for other reviewers". Please don't do
that in the future
eraman added a comment.
I have reverted the commit in r255416 because the test failed in many
architectures. In many cases the linker is not able to find
libclang_rt.profile-$ARCH.a file. There are also other errors. Here is one:
0. Program arguments:
/var/lib/buildbot/slaves/hexagon-buil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255397: Attach maximum function count to Module when using
PGO mode (authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D15163?vs=42549&id=42604#toc
Repository:
rL LLVM
http://rev
eraman marked an inline comment as done.
eraman added a comment.
I've added a test case to check for the presence of MaxFunctionCount module
flag. I'll check in this patch soon.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits
eraman updated this revision to Diff 42549.
eraman added a comment.
Added a test case.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/pgo-max-function-count.c
Index: test/CodeGen/pgo-max-function-count.c
=
rsmith added a subscriber: rsmith.
Comment at: lib/CodeGen/CodeGenModule.cpp:380-381
@@ -379,1 +379,4 @@
+ // In PGO mode, attach maximum function count to the module.
+ if (PGOReader)
+getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());
EmitCtorLis
davidxl added a comment.
LGTM. Wait a little longer in case other reviews want to chime in.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
davidxl added a comment.
Should also add a test case as a followup. Example:
./projects/compiler-rt/test/profile/instrprof-basic.c
David
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
21 matches
Mail list logo
