Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

2015-11-27 Thread Kelvin Li via cfe-commits
kkwli0 closed this revision. kkwli0 added a comment. Committed revision 254207. http://reviews.llvm.org/D15029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

2015-11-26 Thread Kelvin Li via cfe-commits
kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5220-5242 @@ -5216,2 +5219,25 @@ +static bool IsNonNegativeIntegerValue(Expr *&ValExpr, Sema &SemaRef, + OpenMPClauseKind CKind) { + if (!ValExpr->isTypeDependent() && !ValExp

Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

2015-11-26 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5220-5242 @@ -5216,2 +5219,25 @@ +static bool IsNonNegativeIntegerValue(Expr *&ValExpr, Sema &SemaRef, + OpenMPClauseKind CKind) { + if (!ValExpr->isTypeDependent() && !ValEx