Re: [PATCH] D14891: Replace assert with early-out in tryEmitFMulAdd

2015-12-02 Thread Steve Canon via cfe-commits
scanon abandoned this revision. scanon added a comment. Abandoned for http://reviews.llvm.org/D15165. http://reviews.llvm.org/D14891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14891: Replace assert with early-out in tryEmitFMulAdd

2015-11-28 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer added a comment. Is it possible to have a test which covers this change? Comment at: lib/CodeGen/CGExprScalar.cpp:2568 @@ -2567,1 +2567,3 @@ + // that does not have any other uses. if (llvm::BinaryOperator* LHSBinOp = dyn_cast(

Re: [PATCH] D14891: Replace assert with early-out in tryEmitFMulAdd

2015-11-28 Thread Steve Canon via cfe-commits
scanon added a comment. Friendly ping. http://reviews.llvm.org/D14891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits