Re: [PATCH] D14804: [clang] Disable Unicode in asm files

2015-11-20 Thread Vinicius Tinti via cfe-commits
tinti closed this revision. tinti added a comment. r253738 Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

2015-11-19 Thread Renato Golin via cfe-commits
rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM, too. Thanks! Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

2015-11-18 Thread Mehdi AMINI via cfe-commits
joker.eph added a comment. LGTM, please wait for another pair of eye. Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

2015-11-18 Thread Mehdi AMINI via cfe-commits
joker.eph added a comment. Isn't the patch reversed or do I miss something? Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

2015-11-18 Thread Vinicius Tinti via cfe-commits
tinti removed rL LLVM as the repository for this revision. tinti updated this revision to Diff 40595. http://reviews.llvm.org/D14804 Files: lib/Lex/Lexer.cpp test/CodeGen/asm-unicode.S test/CodeGen/c-unicode.c Index: test/CodeGen/c-unicode.c