Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a comment. Yes, I'd like to try. I think this is blocked on the changes that move visibility attributes to the first declaration, right? Also, re: cfi-commits thread for r255177, it appears that on Mac we can neither hide nor expose existing methods (i.e. if something was hidden, i

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. Sorry about the long delay in reviewing this. @eugenis Are you still able/willing to proceed with this? Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a comment. With http://reviews.llvm.org/D15434, there is no difference in libc++ export list with the switch to internal_linkage. Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added dependencies: D15433: [libcxx] Remove inline/visibility attributes from exported template methods in valarray., D15432: [libcxx] Move member function definition before it's explicit template instantiation declaration in to satisfy GCC.. eugenis added a comment. Depends on http://

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a comment. In http://reviews.llvm.org/D14411#306722, @EricWF wrote: > In http://reviews.llvm.org/D14411#306716, @EricWF wrote: > > > Why does this depend on http://reviews.llvm.org/D15404? > > > Woops, I meant the tuple patch but I see the other comment now. I'm curious > as to ho

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. In http://reviews.llvm.org/D14411#306716, @EricWF wrote: > Why does this depend on http://reviews.llvm.org/D15404? Woops, I meant the tuple patch but I see the other comment now. I'm curious as to how inlininging ends up affecting which overload's SFINAE are evaluated.

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. Why does this depend on http://reviews.llvm.org/D15404? Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

rsmith added a subscriber: rsmith. Comment at: include/__config:237 @@ +236,3 @@ +#if __has_attribute(internal_linkage) +#define _LIBCPP_INLINE_VISIBILITY __attribute__ ((internal_linkage)) +#else Use `__internal_linkage__` here. Users are allowed to #define `int

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a dependency: D15404: Cleanup: move visibility/linkage attributes to the first declaration (part 2).. eugenis added a comment. This change depends on http://reviews.llvm.org/D15404. Repository: rL LLVM http://reviews.llvm.org/D14411 __

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a dependency: D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806. eugenis added a comment. Note, this breaks tuple_cat.pass.cpp test. With -O0, replacing always_inline with internal_linkage results in less optimization being done (namely, no inlining h