Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261632: [analyzer] Improve pointer arithmetic checker. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D14203?vs=41022&id=48806#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Other than a suggested diagnostic rewording to consider, looks good to me. Thanks Gábor! Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:198 @@ +197,3 @

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added a comment. Ping. http://reviews.llvm.org/D14203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:150 @@ +149,3 @@ +return getArrayRegion(Region, Polymorphic, AKind, C); + default: +break; xazax.hun wrote: > dcoughlin wrote: > > In general, I think it is b

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun updated this revision to Diff 41022. xazax.hun marked 11 inline comments as done. xazax.hun added a comment. - Fixed some of the review comments. - Updated to latest trunk. http://reviews.llvm.org/D14203 Files: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp test/Analysis/PR24

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:28 @@ -24,1 +27,3 @@ namespace { +enum class AllocKind { + SingletonNew, dcoughlin wrote: > Is it necessary to distinguish so many cases here? For example, why do we

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added a comment. In http://reviews.llvm.org/D14203#287303, @dcoughlin wrote: > Gabor, > > This is an alpha checker. Do you anticipate turning it on by default? > > Comments inline. I could see two kinds of false positives with this checker when running this on the LLVM codebase. Whe

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

dcoughlin added a comment. Gabor, This is an alpha checker. Do you anticipate turning it on by default? Comments inline. Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:28 @@ -24,1 +27,3 @@ namespace { +enum class AllocKind { + SingletonNew,