milianw closed this revision.
milianw added a comment.
closing then, since this has been landed
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ehsan accepted this revision.
ehsan added a reviewer: ehsan.
ehsan added a comment.
Landed in r253909.
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michaelwu added a comment.
Anyone mind landing this for me? I don't have commit access.
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
milianw accepted this revision.
milianw added a comment.
This revision is now accepted and ready to land.
From my POV, this looks good.
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
michaelwu updated this revision to Diff 40100.
michaelwu added a comment.
This removes the test for protected visibility and improves documentation for
clang_getCursorVisibility.
http://reviews.llvm.org/D13388
Files:
include/clang-c/Index.h
test/Index/symbol-visibility.c
tools/c-index-te
michaelwu added inline comments.
Comment at: test/Index/symbol-visibility.c:8
@@ +7,3 @@
+// CHECK: FunctionDecl=foo1:3:47visibility=Default
+// CHECK: FunctionDecl=foo2:4:49visibility=Protected
+// CHECK: FunctionDecl=foo3:5:46visibility=Hidden
skalinichev wrote:
skalinichev added a comment.
Well, I think it's ok then. Still there is no test for visibility set from
command line case.
Also adding comment to clang_getCursorVisibility explaining that it also works
with visibility set from command line would be very useful.
Comment at: te
klimek added a comment.
Sergey, I think you raised concerns whether this is necessary. What are your
thoughts?
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
michaelwu added a comment.
Review ping?
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michaelwu added a comment.
Visibility can be set via command line args without any attributes in the AST,
so I don't think that's sufficient.
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
skalinichev added a comment.
Isn't r246931 what you're looking for?
> Index: expose visibility attribute
>
> Expose the previously unexposed visibility attribute via the python and C
> bindings.
Can't you use/improve that API instead?
http://reviews.llvm.org/D13388
__
milianw added a comment.
Yep, looks good to me as well - thanks!
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a subscriber: klimek.
klimek added a reviewer: milianw.
klimek added a comment.
This LG, looping in Milian for a second opinion / to find more reviewers :)
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.ll
13 matches
Mail list logo
