This revision was automatically updated to reflect the committed changes.
vkalintiris marked an inline comment as done.
Closed by commit rL249137: Add support for the new mips-mti-linux toolchain.
(authored by vkalintiris).
Changed prior to commit:
http://reviews.llvm.org/D13340?vs=36344&id=363
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
vkalintiris updated this revision to Diff 36344.
vkalintiris added a comment.
1. s/MipsToolChain/MipsLLVMToolChain/
2. Change to the new getCompilerRT() return type
3. clang-format
http://reviews.llvm.org/D13340
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.c
atanasyan added inline comments.
Comment at: lib/Driver/Driver.cpp:2225
@@ -2219,1 +2224,3 @@
TC = new toolchains::HexagonToolChain(*this, Target, Args);
+ else if ((Target.getVendor() == llvm::Triple::MipsTechnologies) &&
+ !Target.hasEnvironment())
--
vkalintiris added inline comments.
Comment at: lib/Driver/Driver.cpp:2225
@@ -2219,1 +2224,3 @@
TC = new toolchains::HexagonToolChain(*this, Target, Args);
+ else if ((Target.getVendor() == llvm::Triple::MipsTechnologies) &&
+ !Target.hasEnvironment())
atanasyan added inline comments.
Comment at: lib/Driver/Driver.cpp:2225
@@ -2219,1 +2224,3 @@
TC = new toolchains::HexagonToolChain(*this, Target, Args);
+ else if ((Target.getVendor() == llvm::Triple::MipsTechnologies) &&
+ !Target.hasEnvironment())
--
vkalintiris added inline comments.
Comment at: include/clang/Driver/ToolChain.h:147
@@ -145,1 +146,3 @@
+ const Multilib &getSelectedMultilib() const { return SelectedMultilib; }
+
atanasyan wrote:
> Do you need public access to this member function?
I discarde
vkalintiris updated this revision to Diff 36257.
vkalintiris marked 8 inline comments as done.
vkalintiris added a comment.
Thanks. The review comments are addressed in this update.
http://reviews.llvm.org/D13340
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.
atanasyan added inline comments.
Comment at: include/clang/Driver/ToolChain.h:92
@@ -91,2 +91,3 @@
MultilibSet Multilibs;
+ Multilib SelectedMultilib;
This field is used by the `MipsToolChain` class only. If so, move it to that
class.
Comm
