Re: [PATCH] D13168: [OpenCL] OpenCL2.0 - Apply default address space rules

2016-07-12 Thread Anastasia Stulova via cfe-commits
Anastasia closed this revision. Anastasia added a comment. r253863 http://reviews.llvm.org/D13168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13168: [OpenCL] OpenCL2.0 - Apply default address space rules

2015-10-21 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:6282 @@ +6281,3 @@ +} else if (state.getCurrentChunkIndex() == 0 && + D.getContext() == Declarator::FileContext && + !D.isFunctionDeclarator() && !D.isFunctionDefinition() && ---

Re: [PATCH] D13168: [OpenCL] OpenCL2.0 - Apply default address space rules

2015-10-05 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:6282 @@ +6281,3 @@ +} else if (state.getCurrentChunkIndex() == 0 && + D.getContext() == Declarator::FileContext && + !D.isFunctionDeclarator() && !D.isFunctionDefinition() && ---

Re: [PATCH] D13168: [OpenCL] OpenCL2.0 - Apply default address space rules

2015-09-29 Thread Pekka Jääskeläinen via cfe-commits
pekka.jaaskelainen requested changes to this revision. This revision now requires changes to proceed. Comment at: lib/Sema/SemaType.cpp:6166 @@ -6166,2 +6165,3 @@ attr.setUsedAsTypeAttr(); + hasOpenCLAddressSpace = true; break; Should this be be