Re: [PATCH] D13134: [analyzer] Add keyboard shortcuts to report.html

2015-10-05 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. Thanks for the update. Unfortunately, we can't accept the mousetrap code. Any code contributed to clang needs to be under the UIUC license. The original copyright owner would need to contribute the code under that license. I think it would be fine to revert to your p

Re: [PATCH] D13134: [analyzer] Add keyboard shortcuts to report.html

2015-10-05 Thread Karl Skomski via cfe-commits
skomski removed rL LLVM as the repository for this revision. skomski updated this revision to Diff 36490. skomski added a comment. Included mousetrap to get keyboard shortcuts working on all international keyboards. Fixed behaviour without hash path present: Jump to #Path1 on j or k http://revi

Re: [PATCH] D13134: [analyzer] Add keyboard shortcuts to report.html

2015-09-29 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. Thanks for the patch! This looks very useful. What browsers does the JavaScript support? One thing I noticed is that after immediately loading a new report page the 'j' and 'k' shortcuts don't work for me. In Safari, I get: TypeError: null is not an object (evaluat