Re: [PATCH] D12979: Avoid inlining in exception handling context

2015-09-30 Thread Jun Bum Lim via cfe-commits
junbuml abandoned this revision. junbuml added a comment. Move this clang change in http://reviews.llvm.org/D13304 http://reviews.llvm.org/D12979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D12979: Avoid inlining in exception handling context

2015-09-30 Thread Jun Bum Lim via cfe-commits
junbuml added a comment. In this clang change, I added a state flag (bool IsColdRegion) in CodeGenFunction and set/reset the flag in EmitCXXThrowExpr(). In EmitCall(), the NoInline attribute would be added if IsColdRegion is true. As of now, this change only handles throw statements because I d

Re: [PATCH] D12979: Avoid inlining in exception handling context

2015-09-30 Thread Jun Bum Lim via cfe-commits
junbuml edited subscribers, added: cfe-commits; removed: llvm-commits. junbuml updated this revision to Diff 36107. http://reviews.llvm.org/D12979 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CGException.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/thro

Re: [PATCH] D12979: Avoid inlining in exception handling context

2015-09-30 Thread hfin...@anl.gov via cfe-commits
hfinkel added a comment. You should start a new differential for this, so that you can get a clean summary e-mail with a description sent to cfe-commits. There's some overlap, but you'll also get potentially-different reviewers here. http://reviews.llvm.org/D12979 __