Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-22 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248297: [CUDA] Fixes minor cuda-related issues in the driver (authored by tra). Changed prior to commit: http://reviews.llvm.org/D12892?vs=34855&id=35386#toc Repository: rL LLVM http://reviews.llvm.

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo added a comment. Sure. Seems reasonable. Thanks! -eric http://reviews.llvm.org/D12892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Artem Belevich via cfe-commits
tra added a comment. In http://reviews.llvm.org/D12892#246699, @echristo wrote: > Yuck. No better ideas off the top of my head other than diagnosing and > erroring though. > > (Is that a possibility? :) I need to be able to override preceding options, so no error is intentional. http://revie

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Yuck. No better ideas off the top of my head other than diagnosing and erroring though. (Is that a possibility? :) -eric http://reviews.llvm.org/D12892 __