Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro abandoned this revision. loladiro added a comment. Oh, I see it checks for the null terminator past the end of the given memory block on construction, but if the memory after changes later this just keeps running. Well, that's quite a trap, but I guess that's what you get for not under

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro added a comment. Hmm, you're right. And I am actually constructing it in such a way that it's supposed to have it, so I wonder why it ran off the rails here. Will take another look. Repository: rL LLVM http://reviews.llvm.org/D12854 __

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

klimek added a subscriber: klimek. klimek added a comment. Generally, I thought clang often relies on buffers being null terminated to speed up parse times. Usually the MemoryBuffers have an option to guarantee null-terminatedness (and copy if necessary) Repository: rL LLVM http://reviews.l

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro added a comment. Bump. Could somebody take a look at this? Repository: rL LLVM http://reviews.llvm.org/D12854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits