Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-11-24 Thread Paul Robinson via cfe-commits
probinson added a comment. The problem is that making the install-local target will try to create the PROJ_sharedir directory in parallel with trying to copy DESTFILES to that directory. You need to set up the dependencies such that the directory is guaranteed to be created first. If you move

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-11-20 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. I think will be good idea to ask specialist in configure build to look on make file. I used other Clang or LLVM make file as example. Frankly, I don't see anything bad with it. However this fix was backported to 3.7.x and configure build is still supported there

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-11-20 Thread Paul Robinson via cfe-commits
probinson added a subscriber: probinson. probinson added a comment. Not sure what the exact problem is, but we still have one bot using configure/make, and it dies with this on the install step unless we use -j1. I know the hand-written Makefiles are deprecated and we've worked around it, but

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-17 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247890: [clang-tidy] install helper scripts (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D12700?vs=34953&id=34997#toc Repository: rL LLVM http://reviews.llvm.org/D12700 Fi

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-17 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. LG. Thanks! Repository: rL LLVM http://reviews.llvm.org/D12700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-16 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko set the repository for this revision to rL LLVM. Eugene.Zelenko updated this revision to Diff 34953. Eugene.Zelenko added a comment. I added installation in configure. See also http://reviews.llvm.org/D12919 for further configure improvements idea. Repository: rL LLVM http://r

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-16 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D12700#246948, @sylvestre.ledru wrote: > share/clang is fine, thanks. Then we need to make a similar change to the configure build. Eugene, can you do this? http://reviews.llvm.org/D12700 ___ cf

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-16 Thread Sylvestre Ledru via cfe-commits
sylvestre.ledru added a comment. share/clang is fine, thanks. http://reviews.llvm.org/D12700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-09 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. On my understanding share contains architecture-independent files. clang-format files installation is also part of CMake build only. http://reviews.llvm.org/D12700 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

2015-09-09 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Not sure whether the scripts should go to share/clang or some other place. Sylvestre should know what's the common practice. Also, configure builds are still used for building packages, AFAIU, so they have to be modified as well (preferably, in the same patch). http://